Add JSON Schema Definition for gen_ai.tool.definitions#3378
Open
Cirilla-zmh wants to merge 5 commits intoopen-telemetry:mainfrom
Open
Add JSON Schema Definition for gen_ai.tool.definitions#3378Cirilla-zmh wants to merge 5 commits intoopen-telemetry:mainfrom
Cirilla-zmh wants to merge 5 commits intoopen-telemetry:mainfrom
Conversation
Change-Id: Ib6133b3019195e4fa9a54d329ff4b891a281d208 Co-developed-by: Cursor <noreply@cursor.com>
Cirilla-zmh
commented
Feb 3, 2026
Member
Author
|
I apologize that the previous PR (#2942) was closed due to an incorrect rebase. All comments from the original PR have been addressed, and I believe this PR is now ready to be merged. Here is the change that I have made: 6838193 |
KalleOlaviNiemitalo
left a comment
There was a problem hiding this comment.
These are just my observations. I am not requesting any change.
lmolkova
approved these changes
Feb 4, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #2721 #1835
Changes
This PR is a continuation of #2942 #2793. My apologies for accidentally closing the previous one.
Add JSON schema definition for gen_ai.tool.definitions.
Important
Pull requests acceptance are subject to the triage process as described in Issue and PR Triage Management.
PRs that do not follow the guidance above, may be automatically rejected and closed.
Merge requirement checklist
[chore]