Skip to content

fix: resolve tsconfig paths with tsx#68

Merged
mnapoli merged 9 commits intooss-serverless:mainfrom
zirkelc:fix-60-tsconfig-paths
Jul 6, 2025
Merged

fix: resolve tsconfig paths with tsx#68
mnapoli merged 9 commits intooss-serverless:mainfrom
zirkelc:fix-60-tsconfig-paths

Conversation

@zirkelc
Copy link
Contributor

@zirkelc zirkelc commented Jun 24, 2025

Fixes #60

This PR replaces jiti with tsx to load the serverless.ts config because tsx resolves tsconfig.paths while jiti does not yet (unjs/jiti#373)

I will try to add a new test case with a tsconfig.json and paths.

@zirkelc
Copy link
Contributor Author

zirkelc commented Jun 25, 2025

Sorry, I didn't want to push my local lockfile and the incomplete test.

@mnapoli
Copy link
Contributor

mnapoli commented Jun 25, 2025

Should we remove the jiti dependency too?

@zirkelc
Copy link
Contributor Author

zirkelc commented Jun 25, 2025

@mnapoli sure!

@zirkelc
Copy link
Contributor Author

zirkelc commented Jun 26, 2025

@GrahamCampbell @mnapoli I added a test for tsconfig.json with paths.

@BlakeEddie
Copy link

Hey, sorry to bother everyone but with the comments resolved is this likely unblocked?

No rush I'm just deciding whether I start to migrate to osls this week or hold off

@mnapoli
Copy link
Contributor

mnapoli commented Jul 6, 2025

Thank you for the PR!

@mnapoli mnapoli merged commit 4e7c1c8 into oss-serverless:main Jul 6, 2025
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants