fix: use hash instead of url for primary cache key#102
Conversation
Contributor
|
Hi! I'm I would like to apply some automated changes to this pull request, but it looks like I don't have the necessary permissions to do so. To get this pull request into a mergeable state, please do one of the following two things:
|
autofix.ci
Author
|
@xhyrom ? |
Author
|
i cant allow edits from maintainers because its cross-org fork (https://github.com/orgs/community/discussions/5634) |
Collaborator
|
I'll move it to the dev branch and then create PR from dev -> main. Thanks! |
xhyrom
added a commit
that referenced
this pull request
Oct 8, 2024
* fix: use hash instead of url for primary cache key (#102) * Update cache-save.ts * Update action.ts * Update cache-save.ts * build * format * [autofix.ci] apply automated fixes --------- Co-authored-by: Daniil Zotov <142039751+zoto-ff@users.noreply.github.com> Co-authored-by: autofix-ci[bot] <114827586+autofix-ci[bot]@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
its not working when cache key is URL (because of url unsafe characters or smth i think), so i suggest to hash download url and use it as cache key
fixes #101