[For 10.4] Filter app:list for just enabled or disabled apps

[phil-davis]

Description

Add options to the occ app:list command to display just the enabled or disabled apps.

This is on top of #36165

Motivation and Context

It is often convenient to be able to just display the enabled or disabled apps.

How Has This Been Tested?

Running acceptance tests locally.

Types of changes

• Bug fix (non-breaking change which fixes an issue)
• New feature (non-breaking change which adds functionality)
• Database schema changes (next release will require increase of minor version instead of patch)
• Breaking change (fix or feature that would cause existing functionality to change)
• Technical debt
• Tests only (no source changes)

Checklist:

• Code changes
• Unit tests added
• Acceptance tests added
• Documentation ticket raised: update of occ command reference necessary docs#2141
• Changelog item, see TEMPLATE

[phil-davis]

ToDo if this seems like "a good thing":

• add changelog item
• raise doc issue
• add new command options to docs

[codecov]

Codecov Report

Merging #36520 into master will increase coverage by 0.01%.
The diff coverage is 94.73%.

@@             Coverage Diff              @@
##             master   #36520      +/-   ##
============================================
+ Coverage     64.66%   64.67%   +0.01%     
- Complexity    19049    19057       +8     
============================================
  Files          1269     1268       -1     
  Lines         74498    74504       +6     
  Branches       1311     1311              
============================================
+ Hits          48171    48184      +13     
+ Misses        25941    25934       -7     
  Partials        386      386

Flag	Coverage Δ	Complexity Δ
#javascript	54.02% <ø> (ø)	0 <ø> (ø)	⬇️
#phpunit	65.84% <94.73%> (+0.01%)	19057 <0> (+8)	⬆️

Impacted Files	Coverage Δ	Complexity Δ
core/Command/App/ListApps.php	92.3% <94.73%> (+1.92%)	25 <0> (+7)	⬆️
apps/files_sharing/ajax/publicpreview.php	0% <0%> (ø)	0% <0%> (ø)	⬇️
config/config.apps.sample.php

---

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update cf40428...b989ae8. Read the comment docs.

[pako81]

@phil-davis was it agreed to show the version numbers when no --enabled or --disabled option is given in input?

As far as I understood from #36165 (comment), the expectation was to not show any version number for disabled apps when simply running app:list (the current behavior) but do so when --enabled or --disabled options are being used.

[phil-davis]

was it agreed to show the version numbers when no --enabled or --disabled option is given in input?

I don't know what has been "agreed". With the current code occ app:list will now report version numbers for (some) disabled apps. That is a technical backward-compatibility-break for somebody who is parsing the text output. So it depends if we are generally promising exact backward-compatibility of the text output of occ commands.

We could easily change the logic so that disabled app versions are only reported when the user specifically does occ app:list --disabled

[phil-davis]

I changed the logic so that the version of a disabled app is only displayed when --disabled is specifically requested.

occ app:list show no versions of disabled apps.
occ app:list --disabled shows versions of disabled apps.
occ app:list --disabled --enabled shows versions of disabled apps.

So you can get a full list of apps with versions by doing occ app:list --disabled --enabled

[phil-davis]

@micbar there has been various discussion about this in PR #36165
IMO the code here now does the job(s). It could easily go in 10.4.0 (I wrote acceptance tests as I adjusted the code) If you are happy with that, then add this to the 10.4.0 project.
And get whoever you think is appropriate to review.

[phil-davis]

@micbar doco is reviewed and ready to merge.

Go ahead with this?

[micbar]

@phil-davis Yes, go ahead

[phil-davis]

@micbar needs someone to review the code...

[micbar]

See comments, rest LGTM

[settermjd]

Just a few, minor, changes. I'll preemptively update https://github.com/owncloud/docs/pull/2144/files in line with my comments here.

changes have been done

[phil-davis]

@micbar this is ready for you or some developer person to review the code.

[settermjd]

What about noting that version numbers are displayed, along with when they are displayed for disabled apps which were previously enabled?

[phil-davis]

Should we just do that in the docs?

[settermjd]

Should we just do that in the docs?

Depending on how you look at it, both of these instances are docs. Some are "formal" docs, and some are informal. If the information's in one place, then it may be confusing if it's not in the other. Perhaps it's just me, but this is what I've found in a number of projects over the years, including ownCloud.