-
Notifications
You must be signed in to change notification settings - Fork 2.1k
Include a migration to disable the enterprise_key app if present #37512
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
Thanks for opening this pull request! The maintainers of this repository would appreciate it if you would create a changelog item based on your changes. |
micbar
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LTGM
micbar
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Tests are failing on server install
Codecov Report
@@ Coverage Diff @@
## master #37512 +/- ##
============================================
- Coverage 64.68% 64.67% -0.01%
- Complexity 19336 19339 +3
============================================
Files 1277 1278 +1
Lines 75535 75542 +7
Branches 1331 1331
============================================
Hits 48860 48860
- Misses 26283 26290 +7
Partials 392 392
Continue to review full report at Codecov.
|
2 similar comments
Codecov Report
@@ Coverage Diff @@
## master #37512 +/- ##
============================================
- Coverage 64.68% 64.67% -0.01%
- Complexity 19336 19339 +3
============================================
Files 1277 1278 +1
Lines 75535 75542 +7
Branches 1331 1331
============================================
Hits 48860 48860
- Misses 26283 26290 +7
Partials 392 392
Continue to review full report at Codecov.
|
Codecov Report
@@ Coverage Diff @@
## master #37512 +/- ##
============================================
- Coverage 64.68% 64.67% -0.01%
- Complexity 19336 19339 +3
============================================
Files 1277 1278 +1
Lines 75535 75542 +7
Branches 1331 1331
============================================
Hits 48860 48860
- Misses 26283 26290 +7
Partials 392 392
Continue to review full report at Codecov.
|
|
Migrations don't have tests, so I can't increase the coverage. |
|
It should get run in nightly https://github.com/owncloud/update-testing which uses So after merging this, we will see if it all goes OK overnight. |
|
@micbar IMO this does not need a separate changelog, it is part of the existing enterprise_app-related changes. Please review again. |
Description
Disable the enterprise_key app during the upgrade to 10.5.0.
A warning message will appear in the logs.
Requested as part of the new licensing.
Related Issue
#37510
Motivation and Context
How Has This Been Tested?
Manually checked with an upgrade from 10.4.1 to current master (~ 10.5.0beta2)
Screenshots (if appropriate):
Types of changes
Checklist: