Skip to content

Conversation

@jvillafanez
Copy link
Member

Description

Disable the enterprise_key app during the upgrade to 10.5.0.
A warning message will appear in the logs.
Requested as part of the new licensing.

Related Issue

#37510

Motivation and Context

How Has This Been Tested?

Manually checked with an upgrade from 10.4.1 to current master (~ 10.5.0beta2)

Screenshots (if appropriate):

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Database schema changes (next release will require increase of minor version instead of patch)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Technical debt
  • Tests only (no source changes)

Checklist:

  • Code changes
  • Unit tests added
  • Acceptance tests added
  • Documentation ticket raised:
  • Changelog item, see TEMPLATE

@update-docs
Copy link

update-docs bot commented Jun 10, 2020

Thanks for opening this pull request! The maintainers of this repository would appreciate it if you would create a changelog item based on your changes.

Copy link
Contributor

@micbar micbar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LTGM

@micbar micbar self-requested a review June 10, 2020 12:28
Copy link
Contributor

@micbar micbar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tests are failing on server install

@codecov
Copy link

codecov bot commented Jun 10, 2020

Codecov Report

Merging #37512 into master will decrease coverage by 0.00%.
The diff coverage is 0.00%.

Impacted file tree graph

@@             Coverage Diff              @@
##             master   #37512      +/-   ##
============================================
- Coverage     64.68%   64.67%   -0.01%     
- Complexity    19336    19339       +3     
============================================
  Files          1277     1278       +1     
  Lines         75535    75542       +7     
  Branches       1331     1331              
============================================
  Hits          48860    48860              
- Misses        26283    26290       +7     
  Partials        392      392              
Flag Coverage Δ Complexity Δ
#javascript 54.14% <ø> (ø) 0.00 <ø> (ø)
#phpunit 65.84% <0.00%> (-0.01%) 19339.00 <3.00> (+3.00) ⬇️
Impacted Files Coverage Δ Complexity Δ
core/Migrations/Version20200610110817.php 0.00% <0.00%> (ø) 3.00 <3.00> (?)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 890ef6e...619b32a. Read the comment docs.

2 similar comments
@codecov
Copy link

codecov bot commented Jun 10, 2020

Codecov Report

Merging #37512 into master will decrease coverage by 0.00%.
The diff coverage is 0.00%.

Impacted file tree graph

@@             Coverage Diff              @@
##             master   #37512      +/-   ##
============================================
- Coverage     64.68%   64.67%   -0.01%     
- Complexity    19336    19339       +3     
============================================
  Files          1277     1278       +1     
  Lines         75535    75542       +7     
  Branches       1331     1331              
============================================
  Hits          48860    48860              
- Misses        26283    26290       +7     
  Partials        392      392              
Flag Coverage Δ Complexity Δ
#javascript 54.14% <ø> (ø) 0.00 <ø> (ø)
#phpunit 65.84% <0.00%> (-0.01%) 19339.00 <3.00> (+3.00) ⬇️
Impacted Files Coverage Δ Complexity Δ
core/Migrations/Version20200610110817.php 0.00% <0.00%> (ø) 3.00 <3.00> (?)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 890ef6e...619b32a. Read the comment docs.

@codecov
Copy link

codecov bot commented Jun 10, 2020

Codecov Report

Merging #37512 into master will decrease coverage by 0.00%.
The diff coverage is 0.00%.

Impacted file tree graph

@@             Coverage Diff              @@
##             master   #37512      +/-   ##
============================================
- Coverage     64.68%   64.67%   -0.01%     
- Complexity    19336    19339       +3     
============================================
  Files          1277     1278       +1     
  Lines         75535    75542       +7     
  Branches       1331     1331              
============================================
  Hits          48860    48860              
- Misses        26283    26290       +7     
  Partials        392      392              
Flag Coverage Δ Complexity Δ
#javascript 54.14% <ø> (ø) 0.00 <ø> (ø)
#phpunit 65.84% <0.00%> (-0.01%) 19339.00 <3.00> (+3.00) ⬇️
Impacted Files Coverage Δ Complexity Δ
core/Migrations/Version20200610110817.php 0.00% <0.00%> (ø) 3.00 <3.00> (?)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 890ef6e...619b32a. Read the comment docs.

@jvillafanez
Copy link
Member Author

Migrations don't have tests, so I can't increase the coverage.
This has been tested manually.

@phil-davis
Copy link
Contributor

It should get run in nightly https://github.com/owncloud/update-testing
e.g. https://drone.owncloud.com/owncloud/update-testing/862/1/5

which uses owncloud-daily-master-qa.tar.bz2

So after merging this, we will see if it all goes OK overnight.

@phil-davis phil-davis requested a review from micbar June 11, 2020 08:22
@phil-davis
Copy link
Contributor

@micbar IMO this does not need a separate changelog, it is part of the existing enterprise_app-related changes.

Please review again.

@micbar micbar merged commit 5867c1f into master Jun 12, 2020
@delete-merged-branch delete-merged-branch bot deleted the enterprisekey_migration_disable branch June 12, 2020 13:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants