Add sgi Previews

[micbar]

Description

This is adding support for SGI images
https://en.wikipedia.org/wiki/Silicon_Graphics_Image

The new supported file extensions are

• .sgi or .rgb
  3 colour channels
• .rgba
  3 colour cha-nnels and alpha
• .bw or .int
  black and white
• .inta
  black and white and alpha

These files will be associated with the mimetype image/sgi.
This mimetype is not officially registered. https://www.iana.org/assignments/media-types/media-types.xhtml

Dependency

• This needs the imagick php extension to be installed.

Related Issue

https://github.com/owncloud/enterprise/issues/4131

Motivation and Context

How Has This Been Tested?

• Manual Test using demo files
• Manual Test in the details view
• Manual Test with files_mediaviewer

Demo Files

RGB.zip

Screenshot File List

Screenshot Details View

Screenshot Mediaviewer

Screenshots (if appropriate):

Types of changes

• Bug fix (non-breaking change which fixes an issue)
• New feature (non-breaking change which adds functionality)
• Database schema changes (next release will require increase of minor version instead of patch)
• Breaking change (fix or feature that would cause existing functionality to change)
• Technical debt
• Tests only (no source changes)

Checklist:

• Code changes
• Unit tests added
• Acceptance tests added
• Documentation ticket raised: Document the support for SGI Images docs#2735
• Changelog item, see TEMPLATE

[mmattel]

Maybe to add, This format is supported by ImageMagick, see Wikipedia (https://en.wikipedia.org/wiki/Silicon_Graphics_Image)

Please add a changelog 😅

[micbar]

@mmattel Raised a docs ticket owncloud/docs#2735

[ChrisEdS]

Works as expected. <3

[mmattel]

Will this go when merged into 10.5 or in a subsequent release ?

[micbar]

Will this go when merged into 10.5 or in a subsequent release ?

10.5.0 is closed.

[codecov]

Codecov Report

Merging #37758 into master will decrease coverage by 0.00%.
The diff coverage is 0.00%.

@@             Coverage Diff              @@
##             master   #37758      +/-   ##
============================================
- Coverage     64.71%   64.71%   -0.01%     
- Complexity    19387    19388       +1     
============================================
  Files          1283     1284       +1     
  Lines         75737    75739       +2     
  Branches       1333     1333              
============================================
  Hits          49013    49013              
- Misses        26332    26334       +2     
  Partials        392      392              

Flag	Coverage Δ	Complexity Δ
#javascript	54.03% <ø> (ø)	0.00 <ø> (ø)
#phpunit	65.89% <0.00%> (-0.01%)	19388.00 <1.00> (+1.00)	⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files	Coverage Δ	Complexity Δ
lib/private/Preview/SGI.php	0.00% <0.00%> (ø)	1.00 <1.00> (?)
lib/private/PreviewManager.php	71.85% <ø> (ø)	50.00 <0.00> (ø)

---

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 7a7d638...3e1e919. Read the comment docs.

[codecov]

Codecov Report

Merging #37758 into master will decrease coverage by 0.00%.
The diff coverage is 0.00%.

@@             Coverage Diff              @@
##             master   #37758      +/-   ##
============================================
- Coverage     64.71%   64.71%   -0.01%     
- Complexity    19387    19388       +1     
============================================
  Files          1283     1284       +1     
  Lines         75737    75739       +2     
  Branches       1333     1333              
============================================
  Hits          49013    49013              
- Misses        26332    26334       +2     
  Partials        392      392              

Flag	Coverage Δ	Complexity Δ
#javascript	54.03% <ø> (ø)	0.00 <ø> (ø)
#phpunit	65.89% <0.00%> (-0.01%)	19388.00 <1.00> (+1.00)	⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files	Coverage Δ	Complexity Δ
lib/private/Preview/SGI.php	0.00% <0.00%> (ø)	1.00 <1.00> (?)
lib/private/PreviewManager.php	71.85% <ø> (ø)	50.00 <0.00> (ø)

---

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 7a7d638...3e1e919. Read the comment docs.

[micbar]

@DeepDiver1975 I am not sure about that mimetypes.

Changed it.

[micbar]

Reduced it again to the simple set.

[mmattel]

Are there tests needed ? or merging without (already approved...)

[micbar]

basic unit tests are already done for the parent class

[mmattel]

Maybe asking @phil-davis for help?
I can not assists, tests are my weak point, sorry.

[micbar]

I can also write tests 😄 , IMO the existing tests are enough.

This pr is ready to merge

[phil-davis]

We do not currently have specific automated end-to-end acceptance tests for preview generation of each of the supported file types. There are just "generic" test scenarios for "ordinary" text files.

Making such tests in a useful way (i.e. that know what preview result to really expect for each file type) would need to be a separate issue that can be done according to priority.

[micbar]

ok, merging now.