Translation in the activity stream for shares which expired automatically

[JammingBen]

Description

Add a proper translation in the activity stream for shares which expired automatically. Previous to this, the expiry was authored by a user, which is technically not true.

Related Issue

• Fixes https://github.com/owncloud/enterprise/issues/4455

Screenshots (if appropriate):

Types of changes

• Bug fix (non-breaking change which fixes an issue)
• New feature (non-breaking change which adds functionality)
• Database schema changes (next release will require increase of minor version instead of patch)
• Breaking change (fix or feature that would cause existing functionality to change)
• Technical debt
• Tests only (no source changes)

Checklist:

• Code changes
• Unit tests added
• Acceptance tests added
• Documentation ticket raised:
• Changelog item, see TEMPLATE

[jvillafanez]

I'm not sure if this is right. Technically, the agent is like a virtual user that performs the action on behalf of another user.

Having a "share_expire_author" doesn't fit here. What if there are more actions triggered during the share expiration? They could have the "share_expire_author" for a delete file action, which seems weird. Also note that whoever is listening for the delete file event won't likely take into account a "share_expire_author" agent, or won't receive any special treatment.

I'd prefer to reuse the "automation_author" in this case and try to figure out if the share has expired in a different way. A "cli_author" seems to generic for this case, but we could use a different author.
The question is who performs the share expiration and any other related action that could happen during that time.

[JammingBen]

@jvillafanez

I'd prefer to reuse the "automation_author" in this case and try to figure out if the share has expired in a different way.

What do you think of expanding the event parameters here by shareExpired:

core/lib/private/Share20/Manager.php

Line 1110 in 4d11dd4

$hookParams = [

This way we could use this information in the activity app and add it as param. The author could be automation_author then.

[jvillafanez]

That's fine

[JammingBen]

@jvillafanez I implemented it the way you suggested. Some changes are required in the activity app for this, see owncloud/activity#944. We basically now use the automation author and the shareExpired param to indicate if a share expired.

[sonarqubecloud]

Kudos, SonarCloud Quality Gate passed!

0 Bugs
0 Vulnerabilities
0 Security Hotspots
0 Code Smells

No Coverage information
No Duplication information