Skip to content

fix: hidden (dotted) text files shall be detected as text/plain #40427

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
DeepDiver1975 merged 1 commit into from
Oct 17, 2022
Merged

fix: hidden (dotted) text files shall be detected as text/plain #40427

DeepDiver1975 merged 1 commit into from
Oct 17, 2022

Conversation

@DeepDiver1975
Copy link
Member

@DeepDiver1975 DeepDiver1975 commented Oct 14, 2022 •
edited
Loading

Description

hidden text files .test.txt is not detected as text/plan.

How Has This Been Tested?

  • 🤖

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Database schema changes (next release will require increase of minor version instead of patch)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Technical debt
  • Tests only (no source changes)

Checklist:

  • Code changes
  • Unit tests added
  • Acceptance tests added
  • Documentation ticket raised:
  • Changelog item, see TEMPLATE

@update-docs
Copy link

update-docs bot commented Oct 14, 2022

Thanks for opening this pull request! The maintainers of this repository would appreciate it if you would create a changelog item based on your changes.

@DeepDiver1975 DeepDiver1975 marked this pull request as ready for review October 14, 2022 13:06
@IljaN IljaN self-requested a review October 14, 2022 13:19
@IljaN
Copy link
Contributor

IljaN commented Oct 14, 2022

Thanks! LGTM 👍

@DeepDiver1975 DeepDiver1975 force-pushed the fix/detect-mime-hidden-text-file branch from 3ad820f to 9813504 Compare October 17, 2022 07:24
@sonarqubecloud
Copy link

sonarqubecloud bot commented Oct 17, 2022

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

100.0% 100.0% Coverage
0.0% 0.0% Duplication

@DeepDiver1975 DeepDiver1975 merged commit b079fc9 into master Oct 17, 2022
@delete-merged-branch delete-merged-branch bot deleted the fix/detect-mime-hidden-text-file branch October 17, 2022 08:12
@jnweiger
Copy link
Contributor

jnweiger commented Mar 3, 2023

Confirmed in 10.12.0-rc.2

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@IljaN IljaN IljaN approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@DeepDiver1975 @IljaN @jnweiger