Skip to content

Conversation

@mrow4a
Copy link
Contributor

@mrow4a mrow4a commented Nov 2, 2022

Description

Without this change, server-side Apache Auth (e.g. Shibboleth) resulted in redirect to default owncloud page, instead of last visited page. We now correctly handle redirect_url.

Related Issue

How Has This Been Tested?

  • manually in internal oc2.lab test instance

Types of changes

  • Bug fix (non-breaking change which fixes an issue)

Checklist:

  • Base code changes
  • Make sure to handle corner cases in login
  • Unit tests added
  • Acceptance tests added
  • Changelog item, see TEMPLATE

@mrow4a mrow4a requested a review from DeepDiver1975 November 2, 2022 08:09
@mrow4a mrow4a self-assigned this Nov 2, 2022
@update-docs
Copy link

update-docs bot commented Nov 2, 2022

Thanks for opening this pull request! The maintainers of this repository would appreciate it if you would create a changelog item based on your changes.

@owncloud owncloud deleted a comment from ownclouders Nov 2, 2022
@owncloud owncloud deleted a comment from ownclouders Nov 2, 2022
@owncloud owncloud deleted a comment from ownclouders Nov 2, 2022
@owncloud owncloud deleted a comment from ownclouders Nov 2, 2022
@ownclouders
Copy link
Contributor

ownclouders commented Nov 2, 2022

💥 Acceptance tests pipeline apiFederationToShares2-latest-mariadb10.2-php7.4 failed. The build has been cancelled.

https://drone.owncloud.com/owncloud/core/37187/103

@ownclouders
Copy link
Contributor

💥 Acceptance tests pipeline apiShareOperationsToRoot1-mariadb10.2-php7.4 failed. The build has been cancelled.

https://drone.owncloud.com/owncloud/core/37185/55

@ownclouders
Copy link
Contributor

💥 Acceptance tests pipeline apiShareManagementToRoot-mariadb10.2-php7.4 failed. The build has been cancelled.

https://drone.owncloud.com/owncloud/core/37185/51

@ownclouders
Copy link
Contributor

💥 Acceptance tests pipeline apiShareManagementToShares-mariadb10.2-php7.4 failed. The build has been cancelled.

https://drone.owncloud.com/owncloud/core/37185/52

@mrow4a mrow4a force-pushed the e5450/redirect-url branch 3 times, most recently from b901acc to 14d9ae3 Compare November 7, 2022 07:10
@mrow4a mrow4a force-pushed the e5450/redirect-url branch from 14d9ae3 to 2a1be72 Compare November 15, 2022 14:10
@mrow4a mrow4a force-pushed the e5450/redirect-url branch from 2a1be72 to db97c85 Compare November 21, 2022 06:50
@mrow4a mrow4a requested a review from DeepDiver1975 November 28, 2022 09:39
@DeepDiver1975 DeepDiver1975 merged commit 6ebd138 into master Dec 12, 2022
@delete-merged-branch delete-merged-branch bot deleted the e5450/redirect-url branch December 12, 2022 07:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants