Skip to content

Conversation

@DeepDiver1975
Copy link
Member

@DeepDiver1975 DeepDiver1975 commented Jun 19, 2023

Description

Implements https://owncloud.dev/services/app-registry/apps/

How Has This Been Tested?

  • connect to a server running this PR via ios 12.0.3+ or desktop client 4.0+
  • install only office, ms office and/or collabora
  • upload a supported file format to the server (depending on the installed office apps)
  • open the file ios or the context menu in desktop file manager
  • see an option to open the file in the app "Open in MS Office"
  • browser to the oc server will open and open the file in the app

Screenshots (if appropriate):

Screenshot from 2023-07-05 15-00-39

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Database schema changes (next release will require increase of minor version instead of patch)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Technical debt
  • Tests only (no source changes)

Checklist:

  • Code changes
  • Unit tests added
  • Acceptance tests added
  • Documentation ticket raised:
  • Changelog item, see TEMPLATE

@update-docs
Copy link

update-docs bot commented Jun 19, 2023

Thanks for opening this pull request! The maintainers of this repository would appreciate it if you would create a changelog item based on your changes.

@DeepDiver1975 DeepDiver1975 marked this pull request as draft June 19, 2023 20:29
@DeepDiver1975 DeepDiver1975 force-pushed the feat/app-provider branch 2 times, most recently from 8403f52 to 57d061b Compare June 20, 2023 08:09
@ownclouders
Copy link
Contributor

ownclouders commented Jun 20, 2023

💥 Acceptance tests pipeline webUISharingExt1-latest-chrome-maria10.2-php7.4 failed. The build has been cancelled.

https://drone.owncloud.com/owncloud/core/38645/157

@ownclouders
Copy link
Contributor

💥 Acceptance tests pipeline apiWebdavLocks3-maria10.2-php7.4 failed. The build has been cancelled.

https://drone.owncloud.com/owncloud/core/38628/83

@ownclouders
Copy link
Contributor

💥 Acceptance tests pipeline cliLocalStorage-maria10.2-php7.4 failed. The build has been cancelled.

https://drone.owncloud.com/owncloud/core/38628/110

@ownclouders
Copy link
Contributor

💥 Acceptance tests pipeline apiFederationToShares2-10.9.1-maria10.2-php7.4 failed. The build has been cancelled.

https://drone.owncloud.com/owncloud/core/38628/107

@DeepDiver1975 DeepDiver1975 force-pushed the feat/app-provider branch 4 times, most recently from d600d2e to f6dd368 Compare June 23, 2023 13:18
@DeepDiver1975 DeepDiver1975 force-pushed the feat/app-provider branch 2 times, most recently from fdefb9c to 916d4bf Compare June 28, 2023 07:23
@DeepDiver1975 DeepDiver1975 marked this pull request as ready for review July 21, 2023 08:44
@DeepDiver1975 DeepDiver1975 changed the title feat: implement App Registry https://owncloud.dev/services/app-regist… feat: implement App Registry Jul 21, 2023
@DeepDiver1975
Copy link
Member Author

@mmattel you might want to write some docs about this ;-)

@mmattel
Copy link
Contributor

mmattel commented Jul 21, 2023

via ios 12.0.3+ or desktop client 4.0+

what about android?

thanks for notifying, need to think about how to document this and which repos is affects.

@DeepDiver1975
Copy link
Member Author

Android is not ready yet

@sonarqubecloud
Copy link

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 15 Code Smells

54.3% 54.3% Coverage
0.0% 0.0% Duplication

@jvillafanez
Copy link
Member

I'm worried most of the hardcoded information should be provided by the apps... core should just provide a registration mechanism for the apps to use.
The apps can change the routes and / or the supported mime types. With the current approach, not only we need a new core version to adjust the information, but also the apps must rise the minimum OC version because the feature won't be usable in older OC versions.

@DeepDiver1975
Copy link
Member Author

I'm worried most of the hardcoded information should be provided by the apps... core should just provide a registration mechanism for the apps to use.
The apps can change the routes and / or the supported mime types. With the current approach, not only we need a new core version to adjust the information, but also the apps must rise the minimum OC version because the feature won't be usable in older OC versions.

I fully agree with this - but this is a starting point and needs to grow over time.
Furthermore - none of these urls got changed in the past years and I doubt that there will be any major change to these apps in the scope of oc10. Any new development effort is going into ocis .... 🤷

@pako81
Copy link

pako81 commented Aug 3, 2023

do we want to have this in 10.13? Review is still required.

@phil-davis
Copy link
Contributor

do we want to have this in 10.13? Review is still required.

nobody is mentioned in the "Reviewers" section of the PR. The label "3 - To Review" is set, but nobody is going to get a GitHub notification for that.

@DeepDiver1975
Copy link
Member Author

review was requested via rocketchat and done by jp .....

@mmattel
Copy link
Contributor

mmattel commented Aug 4, 2023

review was requested via rocketchat and done by jp .....

...but no approval made
maybe to add persons to the review list here making it easier to get that approved?

@DeepDiver1975 DeepDiver1975 merged commit 11076ec into master Aug 4, 2023
@delete-merged-branch delete-merged-branch bot deleted the feat/app-provider branch August 4, 2023 10:19
@Salipa-Gurung
Copy link

Salipa-Gurung commented Aug 16, 2023

Tested with:
Client: ownCloud 4.2.0.11670 f5a29b
Server version : ownCloud 10.13.0 beta 1 (stable)

Screenshot (28)

@jnweiger
Copy link
Contributor

confirmed fixed in 10.13.0-rc.1

@jnweiger
Copy link
Contributor

jnweiger commented Aug 28, 2023

Test items

  • enable drawio app
    Route /app/list reports
{"mime-types":[{"mime_type":"application\/x-drawio","app_providers":[{"name":"draw.io","icon":"https:\/\/2.zoppoz.workers.dev:443\/https\/avatars.githubusercontent.com\/u\/1769238?s=200&v=4"}],"ext":"drawio","name":"draw.io (diagrams.net)","description":"draw.io (diagrams.net) document","default_application":"draw.io"}]}
  • enabled drawio and wopi app (no office server configs needed)
{"mime-types":[{"mime_type":"application\/vnd.openxmlformats-officedocument.spreadsheetml.sheet","app_providers":[{"name":"MS Office","icon":"https:\/\/2.zoppoz.workers.dev:443\/https\/www.pikpng.com\/pngl\/m\/343-3435764_onlyoffice-desktop-editors-onlyoffice-logo-clipart.png"}],"ext":"xlsx","name":"Microsoft Excel","description":"Microsoft Excel document","default_application":"MS Office"},{"mime_type":"application\/vnd.openxmlformats-officedocument.wordprocessingml.document","app_providers":[{"name":"MS Office","icon":"https:\/\/2.zoppoz.workers.dev:443\/https\/www.pikpng.com\/pngl\/m\/343-3435764_onlyoffice-desktop-editors-onlyoffice-logo-clipart.png"}],"ext":"docx","name":"Microsoft Word","description":"Microsoft Word document","default_application":"MS Office"},{"mime_type":"application\/vnd.openxmlformats-officedocument.presentationml.presentation","app_providers":[{"name":"MS Office","icon":"https:\/\/2.zoppoz.workers.dev:443\/https\/www.pikpng.com\/pngl\/m\/343-3435764_onlyoffice-desktop-editors-onlyoffice-logo-clipart.png"}],"ext":"pptx","name":"Microsoft Excel","description":"Microsoft Excel document","default_application":"MS Office"},{"mime_type":"application\/x-drawio","app_providers":[{"name":"draw.io","icon":"https:\/\/2.zoppoz.workers.dev:443\/https\/avatars.githubusercontent.com\/u\/1769238?s=200&v=4"}],"ext":"drawio","name":"draw.io (diagrams.net)","description":"draw.io (diagrams.net) document","default_application":"draw.io"}]}
  • enabled drawio and wopi app (no office server configs needed)
{"mime-types":[]}

-> Note that the icon URLS are remote URLs -> #40953

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

9 participants