-
Notifications
You must be signed in to change notification settings - Fork 2.1k
feat: implement App Registry #40843
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: implement App Registry #40843
Conversation
|
Thanks for opening this pull request! The maintainers of this repository would appreciate it if you would create a changelog item based on your changes. |
8403f52 to
57d061b
Compare
|
💥 Acceptance tests pipeline webUISharingExt1-latest-chrome-maria10.2-php7.4 failed. The build has been cancelled. https://drone.owncloud.com/owncloud/core/38645/157 |
|
💥 Acceptance tests pipeline apiWebdavLocks3-maria10.2-php7.4 failed. The build has been cancelled. https://drone.owncloud.com/owncloud/core/38628/83 |
|
💥 Acceptance tests pipeline cliLocalStorage-maria10.2-php7.4 failed. The build has been cancelled. https://drone.owncloud.com/owncloud/core/38628/110 |
|
💥 Acceptance tests pipeline apiFederationToShares2-10.9.1-maria10.2-php7.4 failed. The build has been cancelled. https://drone.owncloud.com/owncloud/core/38628/107 |
d600d2e to
f6dd368
Compare
fdefb9c to
916d4bf
Compare
8d27f2b to
4b693df
Compare
|
@mmattel you might want to write some docs about this ;-) |
what about android? thanks for notifying, need to think about how to document this and which repos is affects. |
|
Android is not ready yet |
|
Kudos, SonarCloud Quality Gate passed! |
|
I'm worried most of the hardcoded information should be provided by the apps... core should just provide a registration mechanism for the apps to use. |
I fully agree with this - but this is a starting point and needs to grow over time. |
|
do we want to have this in 10.13? Review is still required. |
nobody is mentioned in the "Reviewers" section of the PR. The label "3 - To Review" is set, but nobody is going to get a GitHub notification for that. |
|
review was requested via rocketchat and done by jp ..... |
...but no approval made |
|
confirmed fixed in 10.13.0-rc.1 |
Test items
-> Note that the icon URLS are remote URLs -> #40953 |









Description
Implements https://owncloud.dev/services/app-registry/apps/
How Has This Been Tested?
Screenshots (if appropriate):
Types of changes
Checklist: