Skip to content

fix: log.condition with shared_secret shall not break file uploads #41044

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
DeepDiver1975 merged 2 commits into from
Feb 5, 2024
Merged

fix: log.condition with shared_secret shall not break file uploads #41044

DeepDiver1975 merged 2 commits into from
Feb 5, 2024

Conversation

@DeepDiver1975
Copy link
Member

@DeepDiver1975 DeepDiver1975 commented Oct 12, 2023 •
edited by pako81
Loading

Description

Related Issue

Motivation and Context

How Has This Been Tested?

  • test environment:
  • test case 1:
  • test case 2:
  • ...

Screenshots (if appropriate):

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Database schema changes (next release will require increase of minor version instead of patch)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Technical debt
  • Tests only (no source changes)

Checklist:

  • Code changes
  • Unit tests added
  • Acceptance tests added
  • Documentation ticket raised:
  • Changelog item, see TEMPLATE

@DeepDiver1975 DeepDiver1975 force-pushed the fix/log-condition branch 2 times, most recently from 7736a43 to d56b441 Compare October 17, 2023 19:25
@sonarqubecloud
Copy link

sonarqubecloud bot commented Oct 19, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell B 2 Code Smells

92.6% 92.6% Coverage
0.0% 0.0% Duplication

@owncloud owncloud deleted a comment from update-docs bot Nov 16, 2023
phil-davis
phil-davis reviewed Feb 5, 2024
View reviewed changes
Copy link
Contributor

@phil-davis phil-davis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This seems "a good thing", so merge it?

@sonarqubecloud
Copy link

sonarqubecloud bot commented Feb 5, 2024

Quality Gate Passed Quality Gate passed

The SonarCloud Quality Gate passed, but some issues were introduced.

2 New issues
0 Security Hotspots
92.6% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarCloud

@DeepDiver1975 DeepDiver1975 merged commit 19e19ae into master Feb 5, 2024
@delete-merged-branch delete-merged-branch bot deleted the fix/log-condition branch February 5, 2024 12:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@jvillafanez jvillafanez jvillafanez approved these changes

@phil-davis phil-davis phil-davis approved these changes

+1 more reviewer

@pako81 pako81 pako81 approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

3 - To Review

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

log.conditions renders the desktop client unable to synchronize

5 participants

@DeepDiver1975 @jvillafanez @phil-davis @pako81