Skip to content

Conversation

@pako81
Copy link

@pako81 pako81 commented Jan 18, 2024

Description

Update route to richdocuments.document.index

Related Issue

Motivation and Context

https://github.com/owncloud/richdocuments/pull/522/files#diff-6301937af1cc1575e9e18ecd27c4a51f0d3cf9ce12e59a14709f626dfa3ef952R28 (first added in richdocuments 4.1.0) introduced a change to the documents.php/index route.

How Has This Been Tested?

Manually: without this fix the Files->Office menu is not reachable on 10.13.4 + richdocuments 4.1.0. With the fix, menu can be again reached.

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Database schema changes (next release will require increase of minor version instead of patch)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Technical debt
  • Tests only (no source changes)

Checklist:

  • Code changes
  • Unit tests added
  • Acceptance tests added
  • Documentation ticket raised
  • Changelog item

@pako81 pako81 added this to the development milestone Jan 18, 2024
@pako81 pako81 self-assigned this Jan 18, 2024
@update-docs
Copy link

update-docs bot commented Jan 18, 2024

Thanks for opening this pull request! The maintainers of this repository would appreciate it if you would create a changelog item based on your changes.

@sonarqubecloud
Copy link

Quality Gate Passed Quality Gate passed

The SonarCloud Quality Gate passed, but some issues were introduced.

1 New issue
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarCloud

@pako81
Copy link
Author

pako81 commented Jan 23, 2024

Is it ok to merge this?

@DeepDiver1975 DeepDiver1975 changed the title Update route to richdocuments.document.index fix: update route to richdocuments.document.index Jan 23, 2024
@DeepDiver1975 DeepDiver1975 merged commit c9fb009 into master Jan 23, 2024
@delete-merged-branch delete-merged-branch bot deleted the fix_route_to_richdocuments_document_index branch January 23, 2024 15:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants