Skip to content

Conversation

@butonic
Copy link
Member

@butonic butonic commented Feb 18, 2019

add example for html in claim

merge after owncloud/core#30882 has been merged

Signed-off-by: Jörn Friedrich Dreyer [email protected]

@mmattel
Copy link
Contributor

mmattel commented Jun 13, 2019

Any update on this? master and stable10 are merged...

@DeepDiver1975
Copy link
Member

no reviewer - no project - no lable - PRs like that are getting lost 🤷‍♂️

@butonic as usual: please take care of you open PRs ;-)

@butonic
Copy link
Member Author

butonic commented Jun 14, 2019

part of fixing for owncloud/core#30881

documents how to use html in the claim.

  • could be reviewed by @ChrisEdS, @karakayasemi or @settermjd but none of them is available in the reviewers list 🤷‍♂️
  • labels are not in sync with core ... adding enhancement ind good first issue
  • No idea which project to assign this to ...

@butonic butonic added enhancement New feature or request good first issue Good for newcomers labels Jun 14, 2019
@DeepDiver1975
Copy link
Member

* No idea which project to assign this to ...

always "current server *" so the mgmt part of the teams get in on their screen

@DeepDiver1975
Copy link
Member

* could be reviewed by @ChrisEdS, @karakayasemi or @settermjd  but none of them is available in the reviewers list man_shrugging

repo is wrongly setup - fixed now - please fix such situations yourself or let others know - THX

Copy link
Contributor

@karakayasemi karakayasemi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The core change released with 10.2.0 I guess. We need to increase min-max version: https://github.com/owncloud/theme-example/blob/master/appinfo/info.xml#L13

@micbar
Copy link

micbar commented Jun 14, 2019

@karakayasemi yes, commit welcome :-)

@karakayasemi karakayasemi self-assigned this Jun 16, 2019
@karakayasemi karakayasemi merged commit 047372a into master Jun 16, 2019
@delete-merged-branch delete-merged-branch bot deleted the allow-html-in-claim-and-use-htmlname-in-layout branch June 16, 2019 11:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement New feature or request good first issue Good for newcomers

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants