feat!: default to v4 specification #1261
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
BREAKING CHANGE: Pact instances default to version 4 of the Pact
specification (previously used version 3). This should be mostly
backwards compatible, but can be reverted by using
`with_specification("V3")`.
Signed-off-by: JP-Ellis <josh@jpellis.me>
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR changes the default Pact specification version from V3 to V4, representing a breaking change to help promote adoption of the newer specification version.
- Sets the default Pact specification to V4 in the constructor
- Updates documentation to reflect the new default behavior
- Maintains backward compatibility by allowing users to explicitly set V3 if needed
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #1261 +/- ##
====================================
- Coverage 52% 52% -1%
====================================
Files 32 32
Lines 3729 3730 +1
====================================
Hits 1967 1967
- Misses 1762 1763 +1
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
📝 Summary
Change the default Pact specification from V3 to V4.
🚨 Breaking Changes
Pact instances default to version 4 of the Pact specification (previously used version 3). This should be mostly backwards compatible, but can be reverted by using
with_specification("V3").🔥 Motivation
Version 4 of the Pact specification has been available for a while now, and this will help with its adoption.
🔨 Test Plan
🔗 Related issues/PRs