Fix rendering of Enum choices' default #3004
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
Author
|
I think this fix is safe for inclusion into the upcoming 8.2.2 release. |
kdeldycke
added a commit
to kdeldycke/click-extra
that referenced
this pull request
Jul 21, 2025
Collaborator
Author
|
Thanks @Rowlando13 for the merge! :) |
This was referenced Aug 5, 2025
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fix (and test) the rendering of a variety of
Enum-based choices. Specifically their default value in the help/usgae screen.Additionally, it adds a couple of unit tests to lock-in and document the current behavior of choices.
Refs:
ChoiceprefersEnum.nameeven forStrEnumwhere it should use the value #2911