TST: Add test for loc not updating cache correctly #47949
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
you did explicitly check that this exact test fails on 1.4.3? |
|
if so merge when ready. lgtm. Thanks @phofl |
maybe worth adding a code comment to not alter the test as all steps are necessary to avoid clean-ups or refactors changing it. |
|
Yes, used 1.4.3 to narrow it down to this test |
sure. the "Reduced it as far as possible" created some doubt. so was just checking. |
|
Good point, added a comment |
This comment was marked as resolved.
This comment was marked as resolved.
phofl
added a commit
to phofl/pandas
that referenced
this pull request
Aug 3, 2022
* TST: Add test for loc not updating cache correctly * Add comment
noatamir
pushed a commit
to noatamir/pandas
that referenced
this pull request
Nov 9, 2022
* TST: Add test for loc not updating cache correctly * Add comment
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
doc/source/whatsnew/vX.X.X.rstfile if fixing a bug or adding a new feature.All the setitem and getitem steps are necessary to produce the bug. Reduced it as far as possible