Feature: Implement watch methods for PDO driver

[fengqi]

Add saveWatch, getAllWatches, truncateWatches to PdoRepository:

• Equalize data store backends #320

[glensc]

you need to document the breaking change in the PR body.

[fengqi]

you need to document the breaking change in the PR body.

ok

[fengqi]

done

[glensc]

done

Well, the breaking change is that the table is no longer configurable via XHGUI_PDO_TABLE environment variable:

        'table' => getenv('XHGUI_PDO_TABLE') ?: 'results',

[fengqi]

done

Well, the breaking change is that the table is no longer configurable via XHGUI_PDO_TABLE environment variable:

        'table' => getenv('XHGUI_PDO_TABLE') ?: 'results',

change the db table name is not a routine operation, and mongo is not configured, so I hard-coded it in the __construct

[glensc]

I'm saying that the breaking change I described is not in PR body. it's breaking change for users who have relied on the environment variable.

[fengqi]

I see, this is indeed a problem, let me change it back.
do you have any other suggestions on this?

[glensc]

@fengqi I'm saying you need to document it in the pull request body. you can of course restore the breaking change, so then it does not need to be documented.

[fengqi]

i have changed it back
and i will submit other pdo implementation parts later

[glensc]

please consider doing atomic commits for further changes:

• https://www.freshconsulting.com/insights/blog/atomic-commits/
• https://en.wikipedia.org/wiki/Atomic_commit#Atomic_commit_convention

and if previous commit needs to be improved, git commit --fixup.

I'll squash/fixup myself your commits here before the merge.

[fengqi]

please consider doing atomic commits for further changes:

• https://www.freshconsulting.com/insights/blog/atomic-commits/
• https://en.wikipedia.org/wiki/Atomic_commit#Atomic_commit_convention

and if previous commit needs to be improved, git commit --fixup.

I'll squash/fixup myself your commits here before the merge.

got it, I pick all commit from the our used internally branch, so the modification was submitted all at once

[glensc]

I use git format-patch -1 COMMIT and git am 0001-foo.patch to transfer such commits. or if they are in same git repo (just different branches) can git cherry-pick COMMIT

[fengqi]

did i need to reopen a new pr？

[glensc]

@fengqi open new PR for what?

[glensc]

Fixing failing tests 0675a49:

• https://github.com/perftools/xhgui/runs/4126769257?check_suite_focus=true