posix adding posix_fpathconf. #10253
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
78f6442 to
9ff64e6
Compare
Girgias
requested changes
Jan 8, 2023
ext/posix/posix.stub.php
Outdated
| @@ -429,3 +429,4 @@ function posix_initgroups(string $username, int $group_id): bool {} | |||
| function posix_sysconf(int $conf_id): int {} | |||
|
|
|||
| function posix_pathconf(string $path, int $name): int|false {} | |||
| function posix_fpathconf(int $fd, int $name): int|false {} | |||
There was a problem hiding this comment.
Due to the fact resource is not a type you cannot use a proper type declaration here and will need to do it as a doc comment (a bit like how posix_isatty() is marked)
2713814 to
c73a327
Compare
Girgias
reviewed
Jan 10, 2023
c73a327 to
33f4725
Compare
follow-up on phpGH-10238 but with the file descriptor flavor.
33f4725 to
1ea6a5c
Compare
Girgias
approved these changes
Jan 12, 2023
|
Please don't forget to add this to UPGRADING while merging :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
follow-up on GH-10238 but with the file descriptor flavor.