Skip to content

Fix GH-10292 1st param of mt_srand() has UNKNOWN default on PHP <8.3 #10429

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 2 commits into from
Closed

Fix GH-10292 1st param of mt_srand() has UNKNOWN default on PHP <8.3 #10429

wants to merge 2 commits into from

Conversation

kocsismate
Copy link
Member

Rationale: #10380 (review)

@kocsismate kocsismate requested review from TimWolla and cmb69 January 24, 2023 09:21
@TimWolla
Copy link
Member

I don't have sufficient stubs expertise to properly review this. Would it make sense to add a test? The issue specifically noted named parameters:

srand(mode: MT_RAND_MT19937); // No explicit seed, should either choose a random seed or possibly throw.

cmb69
cmb69 approved these changes Jan 24, 2023
View reviewed changes
Copy link
Member

@cmb69 cmb69 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

Would it make sense to add a test? The issue specifically noted named parameters:

I don't think a test with named parameters is necessary, but shouldn't hurt. I'll leave that for @kocsismate to decide. :)

TimWolla
TimWolla approved these changes Jan 24, 2023
View reviewed changes
Copy link
Member

@TimWolla TimWolla left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM with the test.

@kocsismate kocsismate deleted the srand-fix-81 branch January 24, 2023 18:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@TimWolla TimWolla TimWolla approved these changes

@cmb69 cmb69 cmb69 approved these changes

Assignees
No one assigned
Labels
Stubs
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@kocsismate @TimWolla @cmb69