Two enums instead of preprocessor macros

[MaxKellermann]

No description provided.

[devnexen]

Looks correct in general, just curiosity question : what led you to change the original values ?
It seems safe enough doing so, I do not think it will bite later on just curious..

[MaxKellermann]

I reviewed all code locations where they are used, also checked the commit which added them (9c754da), and figured these were arbitrary values with no meaning. I also figured that zero (for which there is no macro) isn't a special case, for example by casting to bool somewhere or relying on zero-initialization (via memset() or bss).
Then I decided to not specifiy any explicit values at all, because that would indicate to the next guy that the values are important, when they really aren't. I decided for simplicity.

[devnexen]

sounds fair.

[highlyprofessionalscum]

I reviewed all code locations where they are used, also checked the commit which added them (9c754da), and figured these were arbitrary values with no meaning. I also figured that zero (for which there is no macro) isn't a special case, for example by casting to bool somewhere or relying on zero-initialization (via memset() or bss). Then I decided to not specifiy any explicit values at all, because that would indicate to the next guy that the values are important, when they really aren't. I decided for simplicity.

please - add this to commit message. and pretty please, with sugar on top - write BIG commit messages to explain next guy WHY this is done. You do a lot of good work, but not explain what and why was done.

[iluuu1994]

Looks good to me, thank you! Can we enable -Wassign-enum on Clang (ASAN build on Cirrus)? This would provide a tangible benefit when converting to enums. Maybe there are other useful enum flags, there's a bunch of them for Clang.

[MaxKellermann]

Can we enable -Wassign-enum on Clang (ASAN build on Cirrus)?

#10641

Though lots of code fails with this warning - and indeed, enums are (ab)used by the JIT and others as bit fields, which is not correct.