use C++ compiler for linking, replaces -lstdc++
#10663
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Merge lots of duplicate code from sapi/*/config.m4. All Darwin-specific cases have been eliminated there.
|
This is a possible fix for #10641 (comment) (sanitizers currently broken with C++) |
If at least one source is C++, ask the C++ compiler to link the executable instead of manually adding `-lstdc++`. The C++ compiler knows best which C++ standard library needs to be used. This is more robust, and allows non-GNU standard libraries such as libc++.
Without this, the sanitizers are disabled on C++ sources.
7787c04 to
8ca9613
Compare
|
macOS failure due to a bug in this PR |
|
Looks correct changes to me but prefer to double check with someone more accustomed to |
|
I don't know much about C++ or the linker, so I'm probably not the right guy to review this one. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If at least one source is C++, ask the C++ compiler to link the executable instead of manually adding
-lstdc++. The C++ compiler knows best which C++ standard library needs to be used. This is more robust, and allows non-GNU standard libraries such as libc++.