Skip to content

Add missing error checks on EVP_MD_CTX_create() and EVP_VerifyInit() #10762

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from
Closed

Add missing error checks on EVP_MD_CTX_create() and EVP_VerifyInit() #10762

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 9 additions & 1 deletion ext/phar/util.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1579,7 +1579,15 @@ int phar_verify_signature(php_stream *fp, size_t end_of_phar, uint32_t sig_type,
}

md_ctx = EVP_MD_CTX_create();
EVP_VerifyInit(md_ctx, mdtype);
if (!md_ctx || !EVP_VerifyInit(md_ctx, mdtype)) {
if (md_ctx) {
EVP_MD_CTX_destroy(md_ctx);
}
if (error) {
spprintf(error, 0, "openssl signature could not be verified");
}
return FAILURE;
}
read_len = end_of_phar;

if ((size_t)read_len > sizeof(buf)) {
Expand Down