Skip to content

Extend test to make sure IntlCalendar::clear() resets month to 0 #11129

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from

Conversation

andypost
Copy link
Contributor

@andypost andypost commented Apr 24, 2023

Related to #11128

This test with ICU 73.1 fails with but pass earlier versions showing that clear() does not reset to 0

TEST 1/1 [ext/intl/tests/calendar_clear_variation1.phpt]
========DIFF========
--
     bool(true)
     bool(false)
     int(1)
005- float(1327813567000)
005+ float(1330491967000)
     bool(true)
     float(1327813567000)
     float(1327813567000)
--
========DONE========
FAIL IntlCalendar::clear() 1 arg variation [ext/intl/tests/calendar_clear_variation1.phpt] 

@andypost
Copy link
Contributor Author

andypost commented Apr 25, 2023

New change demonstrating that clear in 73.1 resets to 1 but was 0 in earlier versions - pipeline job

========DIFF========
     bool(true)
     bool(true)
     bool(false)
004- int(1)
004+ int(0)
     float(1327813567000)
     bool(true)
     float(1327813567000)
--
========DONE========

@@ -25,5 +29,9 @@ var_dump(
bool(true)
bool(true)
bool(false)
int(1)
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this should be 0 but 1 with new ICU

@andypost andypost changed the title Extend test to make sure clear() resets month to 0 Extend test to make sure IntlCalendar::clear() resets month to 0 May 29, 2023
@andypost andypost closed this Jun 26, 2023
@andypost andypost deleted the 11128-calendar branch June 26, 2023 17:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant