Let closure created from magic method accept named parameters #11364
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,102 @@ | ||
| --TEST-- | ||
| Trampoline closure created from magic method accepts named arguments | ||
| --FILE-- | ||
| <?php | ||
|
|
||
| class Test { | ||
| public function __call($name, $args) { | ||
| var_dump($name, $args); | ||
| } | ||
| public static function __callStatic($name, $args) { | ||
| var_dump($name, $args); | ||
| } | ||
| } | ||
|
|
||
| $test = new Test; | ||
|
|
||
| echo "-- Non-static cases --\n"; | ||
| $test->test(...)(1, 2); | ||
| $test->test(...)(1, 2, a: 123, b: $test); | ||
| $test->test(...)(a: 123, b: $test); | ||
| $test->test(...)(); | ||
|
|
||
| echo "-- Static cases --\n"; | ||
| Test::testStatic(1, 2, a: 123); | ||
| Test::testStatic(...)(1, 2); | ||
| Test::testStatic(...)(1, 2, a: 123, b: $test); | ||
| Test::testStatic(...)(a: 123, b: $test); | ||
| Test::testStatic(...)(); | ||
|
|
||
| ?> | ||
| --EXPECT-- | ||
| -- Non-static cases -- | ||
| string(4) "test" | ||
| array(2) { | ||
| [0]=> | ||
| int(1) | ||
| [1]=> | ||
| int(2) | ||
| } | ||
| string(4) "test" | ||
| array(4) { | ||
| [0]=> | ||
| int(1) | ||
| [1]=> | ||
| int(2) | ||
| ["a"]=> | ||
| int(123) | ||
| ["b"]=> | ||
| object(Test)#1 (0) { | ||
| } | ||
| } | ||
| string(4) "test" | ||
| array(2) { | ||
| ["a"]=> | ||
| int(123) | ||
| ["b"]=> | ||
| object(Test)#1 (0) { | ||
| } | ||
| } | ||
| string(4) "test" | ||
| array(0) { | ||
| } | ||
| -- Static cases -- | ||
| string(10) "testStatic" | ||
| array(3) { | ||
| [0]=> | ||
| int(1) | ||
| [1]=> | ||
| int(2) | ||
| ["a"]=> | ||
| int(123) | ||
| } | ||
| string(10) "testStatic" | ||
| array(2) { | ||
| [0]=> | ||
| int(1) | ||
| [1]=> | ||
| int(2) | ||
| } | ||
| string(10) "testStatic" | ||
| array(4) { | ||
| [0]=> | ||
| int(1) | ||
| [1]=> | ||
| int(2) | ||
| ["a"]=> | ||
| int(123) | ||
| ["b"]=> | ||
| object(Test)#1 (0) { | ||
| } | ||
| } | ||
| string(10) "testStatic" | ||
| array(2) { | ||
| ["a"]=> | ||
| int(123) | ||
| ["b"]=> | ||
| object(Test)#1 (0) { | ||
| } | ||
| } | ||
| string(10) "testStatic" | ||
| array(0) { | ||
| } |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I was wondering why we couldn't use the
*named_paramsfield of the FCI struct, before realising that we need to merge all the parameters into a single array to pass as an argument to the magic method.