Skip to content

Fix GH-12167 and GH-12169: Unable to get comment or processing instru… #12289

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 1 commit into from
Closed

Fix GH-12167 and GH-12169: Unable to get comment or processing instru… #12289

wants to merge 1 commit into from

Conversation

nielsdos
Copy link
Member

…ction contents in SimpleXML

This was linked to issues Sep 23, 2023
No way to get the contents of a processing instruction in SimpleXML #12167
Closed
Unable to get comment contents in SimpleXML #12169
Closed
Girgias
Girgias approved these changes Sep 25, 2023
View reviewed changes
Copy link
Member

@Girgias Girgias left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks sensible to me

@nielsdos nielsdos closed this in 82a84d0 Sep 25, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Girgias Girgias Girgias approved these changes

Assignees
No one assigned
Labels
Extension: simplexml
Projects
None yet
Milestone
No milestone
2 participants
@nielsdos @Girgias