Fix GH-12423: [pdo_pgsql] Changed to prioritize DSN authentication information over arguments. #12424
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
would it be possible to add a test ? |
|
Okay, I'll add it later. |
|
I added a test. |
|
Probably it requires a note in UPGRADING as this may change the code behavior for some users. |
devnexen
approved these changes
Oct 12, 2023
f7dcde9 to
c891b1b
Compare
|
While at it, would you mind squashing into 1 commit when you can ? If no one object I ll either commit today or tomorrow. Cheers. |
Added connection test fixed PR number
69239cd to
38deddd
Compare
|
@devnexen |
|
Thank you ! |
|
Thank you! |
nicolas-grekas
added a commit
to symfony/symfony
that referenced
this pull request
Nov 6, 2023
…for PDO PostgreSQL (HypeMC) This PR was merged into the 5.4 branch. Discussion ---------- [Cache][HttpFoundation][Lock] Fix empty username/password for PDO PostgreSQL | Q | A | ------------- | --- | Branch? | 5.4 | Bug fix? | yes | New feature? | no | Deprecations? | no | Issues | - | License | MIT Currently [pdo_pgsql has a bug](php/php-src#12423) where the username & password arguments have precedence over the DSN, even thought [according to the docs](https://www.php.net/manual/en/ref.pdo-pgsql.connection.php) it should be the other way. This was recently fixed on PHP's side, but it [won't be available till 8.4](php/php-src#12424). Since the bug is not present when the values passed are `null`, which are the default argument values anyway, this PR changes the default values of the properties to match. Commits ------- 534c34c [Cache][HttpFoundation][Lock] Fix empty username/password for PDO PostgreSQL
symfony-splitter
pushed a commit
to symfony/cache
that referenced
this pull request
Nov 6, 2023
…for PDO PostgreSQL (HypeMC) This PR was merged into the 5.4 branch. Discussion ---------- [Cache][HttpFoundation][Lock] Fix empty username/password for PDO PostgreSQL | Q | A | ------------- | --- | Branch? | 5.4 | Bug fix? | yes | New feature? | no | Deprecations? | no | Issues | - | License | MIT Currently [pdo_pgsql has a bug](php/php-src#12423) where the username & password arguments have precedence over the DSN, even thought [according to the docs](https://www.php.net/manual/en/ref.pdo-pgsql.connection.php) it should be the other way. This was recently fixed on PHP's side, but it [won't be available till 8.4](php/php-src#12424). Since the bug is not present when the values passed are `null`, which are the default argument values anyway, this PR changes the default values of the properties to match. Commits ------- 534c34cb79 [Cache][HttpFoundation][Lock] Fix empty username/password for PDO PostgreSQL
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes #12423
I was a little worried about which branch to target, but decided to target master because the behavior would change.