Fix GH-11374, backport upstream pcre2 fix #12439
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nielsdos
approved these changes
Oct 14, 2023
There was a problem hiding this comment.
Looks like a correct backport, thanks.
I'm a bit worried about backporting a non-released fix, because it hasn't been "battle tested", but maybe that's okay.
I'll leave this open for a few days (we have plenty of time anyway before the next release cut-off) and if no complaints come in I'll merge.
|
RM opinion? @ramsey @adoy @patrickallaert |
adoy
approved these changes
Oct 17, 2023
|
@ramsey @patrickallaert We haven't heard from you yet 🙂 . Are you ok with backporting to 8.1? It's basically our last chance to get it into 8.1 (which could of course be risky as well). |
|
If we're backporting it to 8.2, I don't have a problem backporting it to 8.1. |
Same point of view on my side. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
issue: #11374
discussion: PCRE2Project/pcre2#261
upstream fix: PCRE2Project/pcre2#300
repro: https://3v4l.org/a9nLn