Fixed regular expression to get password from dsn

[SakiTakamachi]

cc: @devnexen
The regular expression was wrong

take2 of: #12446

[devnexen]

ah that happens we ll get there :-) I ll review in couple of hours cheers.

[SakiTakamachi]

I don't want to merge to master too many times and fail, so I'm trying to copy the branch to my CI and run it.

Can you see this?

https://app.circleci.com/pipelines/github/SakiTakamachi/php-src/2/workflows/fdb0b962-9c7c-4657-a81f-0157f93b6fa2/jobs/2

[SakiTakamachi]

My CI passed

[devnexen]

Thanks again !

[mbeccati]

My CI is not passing as I have no password (using peer authentication for tests). I will look into a fix, or adding a skipif.

For reference: https://revive.beccati.com/bamboo/browse/PHP-SRC-TESTS-3559/test/case/76220624

[SakiTakamachi]

Ah, I overlooked that case. If the password cannot be retrieved from the DSN, it should have passed null instead of skipping.

[SakiTakamachi]

No, it seems better to skip when using peer connect. This test looks at the behavior when there is not peer connection.

[mbeccati]

Yeah, I guess you're right. It's not possible to identify what kind of authentication is going to be used, so I'd suggest skipping if there's no password in the DSN.