Skip to content

Fix: pdo pgsql test 12423 #12454

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Oct 23, 2023
Merged

Fix: pdo pgsql test 12423 #12454

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
45 changes: 26 additions & 19 deletions ext/pdo_pgsql/tests/gh12423.phpt
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,10 +1,15 @@
--TEST--
GitHub #12424 (Fix GH-12423: [pdo_pgsql] Changed to prioritize DSN authentication information over arguments.)
--EXTENSIONS--
pdo
pdo_pgsql
--SKIPIF--
<?php
if (!extension_loaded('pdo') || !extension_loaded('pdo_pgsql')) die('skip not loaded');
require __DIR__ . '/../../../ext/pdo/tests/pdo_test.inc';
require __DIR__ . '/config.inc';
if (strpos($config['ENV']['PDOTEST_DSN'], 'password=') === false && !isset($config['ENV']['PDOTEST_PASS'])) {
die('skip no password');
}
PDOTest::skip();
?>
--FILE--
Expand All @@ -15,53 +20,55 @@ $dsnWithCredentials = $config['ENV']['PDOTEST_DSN'];
$user = $config['ENV']['PDOTEST_USER'] ?? null;
$password = $config['ENV']['PDOTEST_PASS'] ?? null;
if (!$user) {
preg_match('/user=(.*?) /', $dsnWithCredentials, $match);
preg_match('/user=([^ ]*)/', $dsnWithCredentials, $match);
$user = $match[1] ?? '';
}
if (!$password) {
preg_match('/password=(.*?)$/', $dsnWithCredentials, $match);
preg_match('/password=([^ ]*)/', $dsnWithCredentials, $match);
$password = $match[1] ?? '';
}
$dsn = str_replace(" user={$user} password={$password}", '', $dsnWithCredentials);
$dsn = str_replace("user={$user}", '', $dsnWithCredentials);
$dsn = str_replace("password={$password}", '', $dsn);
$dsn = rtrim($dsn);

echo "dsn without credentials / correct user / correct password\n";
echo "dsn without credentials / correct user / correct password".PHP_EOL;
try {
$db = new PDO($dsn, $user, $password, [PDO::ATTR_ERRMODE => PDO::ERRMODE_EXCEPTION]);
echo "Connected.\n\n";
echo "Connected.".PHP_EOL.PHP_EOL;
} catch (PDOException $e) {
echo $e->getMessage();
echo $e->getMessage().PHP_EOL;
}

echo "dsn with credentials / no user / no password\n";
echo "dsn with credentials / no user / no password".PHP_EOL;
try {
$db = new PDO("{$dsn} user={$user} password={$password}", null, null, [PDO::ATTR_ERRMODE => PDO::ERRMODE_EXCEPTION]);
echo "Connected.\n\n";
echo "Connected.".PHP_EOL.PHP_EOL;
} catch (PDOException $e) {
echo $e->getMessage();
echo $e->getMessage().PHP_EOL;
}

echo "dsn with correct user / incorrect user / correct password\n";
echo "dsn with correct user / incorrect user / correct password".PHP_EOL;
try {
$db = new PDO("{$dsn} user={$user}", 'hoge', $password, [PDO::ATTR_ERRMODE => PDO::ERRMODE_EXCEPTION]);
echo "Connected.\n\n";
echo "Connected.".PHP_EOL.PHP_EOL;
} catch (PDOException $e) {
echo $e->getMessage();
echo $e->getMessage().PHP_EOL;
}

echo "dsn with correct password / correct user / incorrect password\n";
echo "dsn with correct password / correct user / incorrect password".PHP_EOL;
try {
$db = new PDO("{$dsn} password={$password}", $user, 'fuga', [PDO::ATTR_ERRMODE => PDO::ERRMODE_EXCEPTION]);
echo "Connected.\n\n";
echo "Connected.".PHP_EOL.PHP_EOL;
} catch (PDOException $e) {
echo $e->getMessage();
echo $e->getMessage().PHP_EOL;
}

echo "dsn with correct credentials / incorrect user / incorrect password\n";
echo "dsn with correct credentials / incorrect user / incorrect password".PHP_EOL;
try {
$db = new PDO("{$dsn} user={$user} password={$password}", 'hoge', 'fuga', [PDO::ATTR_ERRMODE => PDO::ERRMODE_EXCEPTION]);
echo "Connected.\n";
echo "Connected.".PHP_EOL;
} catch (PDOException $e) {
echo $e->getMessage();
echo $e->getMessage().PHP_EOL;
}
?>
--EXPECT--
Expand Down