[RFC?] Add curl websocket bindings#18249
Draft
ndossche wants to merge 1 commit intophp:masterfrom
Draft
Conversation
Member
|
I think this should have RFC |
Member
|
Assuming you were asking about whether it should have RFC with that subject [RFC?]... :) |
Member
Author
|
I agree it needs an RFC, just wasn't sure if I was gonna do it. I'll wait for my other RFC to enter voting to start on this. |
This adds bindings to Curl's websocket support that was added in Curl 7.86.0. Instead of just pass-through C bindings, the API added here is a little more high-level from a type-safety perspective. I.e. this introduces an enum CurlWsMessageType and a DTO class CurlWsFrame for nicer and safer API handling. Still WIP.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This adds bindings to Curl's websocket support that was added in Curl 7.86.0. Instead of just pass-through C bindings, the API added here is a little more high-level from a type-safety perspective. I.e. this introduces an enum CurlWsMessageType and a DTO class CurlWsFrame for nicer and safer API handling.
Still WIP.