Skip to content

Fix GH-18322: SplObjectStorage debug handler mismanages memory #18323

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
ndossche wants to merge 1 commit into from
Closed

Fix GH-18322: SplObjectStorage debug handler mismanages memory #18323

ndossche wants to merge 1 commit into from

Conversation

@ndossche
Copy link
Member

@ndossche ndossche commented Apr 14, 2025

This hack was once necessary before there was a proper get_gc handler, but now it breaks the engine constraints.

@ndossche ndossche requested a review from Girgias as a code owner April 14, 2025 09:28
@ndossche ndossche linked an issue Apr 14, 2025 that may be closed by this pull request
SplObjectStorage debug handler mismanages memory #18322
Closed
@ndossche
Fix phpGH-18322: SplObjectStorage debug handler mismanages memory
1424fdc 
This hack was once necessary before there was a proper get_gc handler,
but now it breaks the engine constraints.
Girgias
Girgias approved these changes Apr 14, 2025
View reviewed changes
Copy link
Member

@Girgias Girgias left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

@ndossche ndossche closed this in 6750387 Apr 14, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@Girgias Girgias Girgias approved these changes

Assignees

No one assigned

Labels

Extension: spl

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

SplObjectStorage debug handler mismanages memory

2 participants

@ndossche @Girgias