Skip to content

2 minor machine code bloat reductions in url.c #18379

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Apr 22, 2025
Merged

2 minor machine code bloat reductions in url.c #18379

merged 2 commits into from
Apr 22, 2025

Conversation

nielsdos
Copy link
Member

No description provided.

@nielsdos nielsdos changed the title 2 minor code bloat reductions in url.c 2 minor machine code bloat reductions in url.c Apr 21, 2025
nielsdos added 2 commits April 21, 2025 14:51
@nielsdos
Add assertion as optimization hint in php_url_encode_impl()
b12bb17 
This avoids the code bloat induced by zend_string_truncate().
@nielsdos
Use RETURN_NEW_STR() in url.c
59cb5d9 
This avoids an extra branch.
@nielsdos nielsdos marked this pull request as ready for review April 21, 2025 13:40
@nielsdos nielsdos requested a review from bukka as a code owner April 21, 2025 13:40
arnaud-lb
arnaud-lb approved these changes Apr 22, 2025
View reviewed changes
Copy link
Member

@arnaud-lb arnaud-lb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me!

@nielsdos nielsdos merged commit 68794e0 into php:master Apr 22, 2025
9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@arnaud-lb arnaud-lb arnaud-lb approved these changes

@bukka bukka Awaiting requested review from bukka bukka is a code owner

Assignees
No one assigned
Labels
Extension: standard
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@nielsdos @arnaud-lb