ext/intl: BreakIterator clean-up #18419
Open
+55
−65
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
devnexen
reviewed
Apr 24, 2025
devnexen
reviewed
Apr 24, 2025
nielsdos
reviewed
Apr 24, 2025
devnexen
reviewed
Apr 26, 2025
| static inline RuleBasedBreakIterator *fetch_rbbi(BreakIterator_object *bio) { | ||
| return (RuleBasedBreakIterator*)bio->biter; | ||
| static inline RuleBasedBreakIterator *fetch_rbbi(const BreakIterator_object *bio) { | ||
| return dynamic_cast<RuleBasedBreakIterator *>(bio->biter); |
There was a problem hiding this comment.
nit: sanity check assigning to a variable and ZEND_ASSERT(var != nullptr);
devnexen
reviewed
Apr 26, 2025
| @@ -34,5 +30,5 @@ U_CFUNC PHP_METHOD(IntlCodePointBreakIterator, getLastCodePoint) | |||
|
|
|||
| BREAKITER_METHOD_FETCH_OBJECT; | |||
|
|
|||
| RETURN_LONG(fetch_cpbi(bio)->getLastCodePoint()); | |||
| RETURN_LONG(dynamic_cast<CodePointBreakIterator *>(bio->biter)->getLastCodePoint()); | |||
There was a problem hiding this comment.
I would try to be consistent here
devnexen
reviewed
Apr 26, 2025
| static inline RuleBasedBreakIterator *fetch_rbbi(BreakIterator_object *bio) { | ||
| return (RuleBasedBreakIterator*)bio->biter; | ||
| static inline RuleBasedBreakIterator *fetch_rbbi(const BreakIterator_object *bio) { | ||
| ZEND_ASSERT(bio != nullptr); |
There was a problem hiding this comment.
You may not need this helper no more than you needed the other, especially I see in one instance (i.e. getRuleStatusVec) that the cast seems to be done needlessly twice (was already like this though) ?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Basically I followed CLion's suggestions about "C++ code smells" not sure if we want to do this or not.
@devnexen I let you be the judge as you primarily maintain this extension