Use interned strings for class properties in stub-generated files#20015
Open
ndossche wants to merge 1 commit intophp:masterfrom
Open
Use interned strings for class properties in stub-generated files#20015ndossche wants to merge 1 commit intophp:masterfrom
ndossche wants to merge 1 commit intophp:masterfrom
Conversation
Girgias
approved these changes
Sep 30, 2025
devnexen
approved these changes
Sep 30, 2025
kocsismate
reviewed
Sep 30, 2025
| $propertyName, | ||
| $this->phpVersionIdMinimumCompatibility | ||
| $this->phpVersionIdMinimumCompatibility, | ||
| true |
Member
There was a problem hiding this comment.
could the parameter be made required so that the same omission becomes less likely next time?
kocsismate
approved these changes
Sep 30, 2025
Member
kocsismate
left a comment
There was a problem hiding this comment.
Very nice catch, thanks for finding this!
zeriyoshi
approved these changes
Oct 1, 2025
derickr
reviewed
Jan 13, 2026
Member
derickr
left a comment
There was a problem hiding this comment.
I don't mind this change, but it seems it needs a rebase now?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.