Add stream socket keepalive context options #20381
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This adds so_keepalive, tcp_keepidle, tcp_keepintvl and tcp_keepcnt stream socket context options that are used to set their upper case C macro variants by setsockopt function. The test requires sockets extension and just tests that the values are being set. This is because a real test would be slow and difficult to show that those options really work due to how they work internally.
|
Is it possible please to also have TCP_USER_TIMEOUT constant added to sockets and made available to be set in the context along with this change? Helps in detecting half closed connections and goes hand in hand with KEEPALIVE https://blog.cloudflare.com/when-tcp-sockets-refuse-to-die/ This is how I currently need to do it, being able to provide it via context would be a big benefit (For example I need to hack around in ReactPHP/Socket to be able to set this flag because the stream is not easily accessible but context can be provided) if (!defined('TCP_USER_TIMEOUT')) {
define("TCP_USER_TIMEOUT", 18);
}
$internalSocket = socket_import_stream($stream);
socket_setopt($internalSocket, SOL_TCP, TCP_USER_TIMEOUT, 15000); //ms |
|
Yeah that could be added but probs in different PR. |
bukka
commented
Nov 5, 2025
| #else | ||
| #define PHP_STREAM_XPORT_IS_UNIX(_stream) false | ||
| #endif | ||
| #define PHP_STREAM_XPORT_IS_UDP(_stream) (_stream->ops == &php_stream_udp_socket_ops) |
There was a problem hiding this comment.
I should replace those with php_stream_is
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds so_keepalive, tcp_keepidle, tcp_keepintvl and tcp_keepcnt stream socket context options that are used to set their upper case C macro variants by setsockopt function.
The test requires sockets extension and just tests that the values are being set. This is because a real test would be slow and difficult to show that those options really work due to how they work internally.