Update license years for PHP 8.4#20388
Open
Mdsujansarkar wants to merge 3 commits intophp:PHP-8.4from
Open
Conversation
Member
|
hmmm I would suggest not to mix topics. |
devnexen
reviewed
Nov 4, 2025
|
|
||
| if (engine->engine.algo->serialize) { | ||
| array_init(&t); | ||
| zend_hash_str_add(Z_ARR_P(return_value), "__states", strlen("__states"), &t); |
Member
There was a problem hiding this comment.
if you think there is an actual memory leak, please do a separated PR.
It is also better to create a branch from an appropriate origin branch.
Contributor
Author
There was a problem hiding this comment.
Revert this line.
Member
|
Such changes have historically only been made on master, I believe. I don't think this should be backported. Even if, then why 8.4 instead of 8.3? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Update license years for PHP 8.4