Skip to content

Add values() Method to BackedEnum #20398

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 10 commits into
base: master
Choose a base branch
from
+278 −10
Open

Add values() Method to BackedEnum #20398

Changes from 1 commit
Commits
Show all changes
10 commits
Select commit Hold shift + click to select a range
56c0a00
Zend: Add ZEND_STR_VALUES interned string
savinmikhail Nov 5, 2025
4da74a9
Zend: Add BackedEnum::values() static method
savinmikhail Nov 5, 2025
38b650e
Reflection: Include BackedEnum::values() in ReflectionEnum and add re…
savinmikhail Nov 5, 2025
6316025
Tests: Add BackedEnum::values() test suite for enums
savinmikhail Nov 5, 2025
91a9daf
Docs: NEWS, UPGRADING: Document BackedEnum::values()
savinmikhail Nov 5, 2025
941f17c
Zend: Respect user-defined values() on BackedEnum
savinmikhail Nov 6, 2025
ae7395a
Tests: Add user-defined BackedEnum::values() override test
savinmikhail Nov 6, 2025
b4d9250
Reflection: Add test for user-defined BackedEnum::values()
savinmikhail Nov 6, 2025
72b3c89
Zend: Use EX(func) and avoid tmp zval copy in zend_enum_values_func()
savinmikhail Nov 6, 2025
0095c97
Reflection: Add test for user-defined BackedEnum::values()
savinmikhail Nov 7, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Zend: Respect user-defined values() on BackedEnum
  • Loading branch information
@savinmikhail
savinmikhail committed Nov 6, 2025
commit 941f17c8dab2be6bc01ad236f228b7ff93041e74
21 changes: 12 additions & 9 deletions Zend/zend_enum.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -495,15 +495,18 @@ void zend_enum_register_funcs(zend_class_entry *ce)
try_from_function->arg_info = (zend_internal_arg_info *) (arginfo_class_BackedEnum_tryFrom + 1);
zend_enum_register_func(ce, ZEND_STR_TRYFROM_LOWERCASE, try_from_function);

zend_internal_function *values_function = zend_arena_calloc(&CG(arena), sizeof(zend_internal_function), 1);
values_function->handler = zend_enum_values_func;
values_function->function_name = ZSTR_KNOWN(ZEND_STR_VALUES);
values_function->fn_flags = fn_flags;
values_function->doc_comment = NULL;
values_function->num_args = 0;
values_function->required_num_args = 0;
values_function->arg_info = (zend_internal_arg_info *) (arginfo_class_BackedEnum_values + 1);
zend_enum_register_func(ce, ZEND_STR_VALUES, values_function);
/* Avoid BC break: if user already declared values(), do not register native */
if (!zend_hash_exists(&ce->function_table, ZSTR_KNOWN(ZEND_STR_VALUES))) {
zend_internal_function *values_function = zend_arena_calloc(&CG(arena), sizeof(zend_internal_function), 1);
values_function->handler = zend_enum_values_func;
values_function->function_name = ZSTR_KNOWN(ZEND_STR_VALUES);
values_function->fn_flags = fn_flags;
values_function->doc_comment = NULL;
values_function->num_args = 0;
values_function->required_num_args = 0;
values_function->arg_info = (zend_internal_arg_info *) (arginfo_class_BackedEnum_values + 1);
zend_enum_register_func(ce, ZEND_STR_VALUES, values_function);
}
}
}

Expand Down