Make curl brotli and zstd optional on Windows#21925
Open
shivammathur wants to merge 1 commit intophp:PHP-8.2from
Open
Make curl brotli and zstd optional on Windows#21925shivammathur wants to merge 1 commit intophp:PHP-8.2from
shivammathur wants to merge 1 commit intophp:PHP-8.2from
Conversation
This allows builds with older curl versions to continue without these dependencies, while also supporting static library names when they are present. Co-authored-by: Jan Ehrhardt <1757825+Jan-E@users.noreply.github.com>
saundefined
approved these changes
May 5, 2026
Member
saundefined
left a comment
There was a problem hiding this comment.
Thanks!
I have no objections, if @adoy also supports it, go ahead.
Contributor
|
FWIW: I even backported this change to PHP 7.4, which I compile sometimes in 2 different build environments
It did exactly what it was supposed to do: brotli in curl was supported in the VS16 env (zstd probably as well, but PHP 7.4 does not report that). In the VS15 env the compilation went as it has always been. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
As requested by @Jan-E here winlibs/cURL#26