Implement sqliteBlobOpen for pdo_sqlite, matching SQLite3 extension #2698
Conversation
| stream->eof = 0; | ||
| return 0; | ||
| } | ||
| } else { |
There was a problem hiding this comment.
Note: since all blocks return early, else and else if are not needed
|
A new method is an API change to me, so an RFC would be warranted. I'm reluctant to add driver-specific methods, since that seems opposed to PDO's driver-agnostic API, but that's not to say we couldn't hash something out. |
|
Let's get the discussion about RFC on internals :) |
|
Can we know the status here, link to internals (externals.io) discussion would be useful ? |
|
Hey Joe, thanks for approving my account on the wiki. Discussion is here: https://externals.io/message/100268 I'll do a RFC proposal asap. I didn't think it would be necessary as this is not changing much, but as some people objected on internals, not against my patch but against the existing PDO way of doing things, I'll do a RFC for that patch. I will update this pull request to remove the conflict with #2734 and do another one for the implementation of sqlite_stmt_readonly. Probably next week or so. |
…o-sqlite-blob Conflicts: ext/pdo_sqlite/pdo_sqlite.c
|
Comment on behalf of cmb at php.net: Since the respective RFC has been declined, I'm closing this PR. |
This adds one new method PDO::sqliteOpenBlob(string table, string column, int rowid [, string dbname [, int flags]])
flags can be either PDO::SQLITE_OPEN_READONLY or PDO::SQLITE_OPEN_READWRITE
This is matching the implementation done in the SQLite3 extension (as SQLite3::openBlob).