Skip to content

Add a CODEOWNERS file #8670

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from
Closed

Add a CODEOWNERS file #8670

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
13 changes: 13 additions & 0 deletions .github/CODEOWNERS
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,13 @@
# The following volunteers have self-identified as subject matter experts
# or interested parties over a particular area of the php-src source code.
# While requesting a review from someone does not obligate that person to
# review a pull request, these reviewers might have valuable knowledge of
# the problem area and could aid in deciding whether a pull request is ready
# for merging.
#
# For more information, see the GitHub CODEOWNERS documentation:
# https://docs.github.com/en/repositories/managing-your-repositorys-settings-and-features/customizing-your-repository/about-code-owners

/ext/date/ @derickr
/ext/oci8/ @cjbj
/ext/pdo_oci/ @cjbj
Comment on lines +12 to +13
Copy link
Member

@cmb69 cmb69 Dec 9, 2022 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't think we should list people without their explicit consent (@derickr already said he likes to be informed about ext/date issues), except maybe for those five maintainers in EXTENSIONS which are listed for 2022.

Suggested change
/ext/oci8/ @cjbj
/ext/pdo_oci/ @cjbj
/ext/com_dotnet/ @cmb69
/ext/gd/ @cmb69
/ext/oci8/ @cjbj
/ext/pdo_oci/ @cjbj

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You can list me if it makes sense. My affiliation is not a secret !

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Updated the suggestion above.