Skip to content

Fix GH-8691 Add required extensions for redirected tests #8724

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from

Conversation

Girgias
Copy link
Member

@Girgias Girgias commented Jun 7, 2022

No description provided.

@Girgias Girgias requested a review from cmb69 June 7, 2022 12:12
@Girgias
Copy link
Member Author

Girgias commented Jun 7, 2022

I just checked and the common tests for PDO ODBC, PGSQL and MySQL are being run

@cmb69
Copy link
Member

cmb69 commented Jun 7, 2022

Great, thank you! Apparently, almost 300 tests are no longer skipped for AppVeyor job 1!

Apparently, there is still an issue, see https://ci.appveyor.com/project/php/php-src/builds/43782237/job/w4xkjhfde5p9w3as?fullLog=true#L10598. Looks like pdo_sqlite is loaded twice. I think we need to fix this test anyway; as is, it always tests pdo_sqlite, and as such wouldn't require a redirect test at all; I guess the original intent was to run it for all available drivers, though.

And I think this patch should target PHP-8.1.

@cmb69 cmb69 linked an issue Jun 7, 2022 that may be closed by this pull request
@Girgias
Copy link
Member Author

Girgias commented Jun 8, 2022

Merged as c05c96b

@Girgias Girgias closed this Jun 8, 2022
@Girgias Girgias deleted the fix-gh8691 branch June 8, 2022 10:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

PDO redirect tests are skipped for shared drivers
2 participants