Skip to content

Replace reallocarray with safe_perealloc #9593

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Sep 22, 2022
Merged

Replace reallocarray with safe_perealloc #9593

merged 1 commit into from
Sep 22, 2022

Conversation

iluuu1994
Copy link
Member

Fixes GH-9581

As per this comment: #9567 (comment)

@iluuu1994 iluuu1994 requested a review from devnexen September 22, 2022 09:58
Girgias
Girgias approved these changes Sep 22, 2022
View reviewed changes
Copy link
Member

@Girgias Girgias left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

devnexen
devnexen approved these changes Sep 22, 2022
View reviewed changes
Copy link
Member

@devnexen devnexen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@iluuu1994 iluuu1994 merged commit b61c81c into php:master Sep 22, 2022
@iluuu1994 iluuu1994 deleted the replace-reallocarray-with-safe-perealloc branch September 22, 2022 12:55
@zeriyoshi
Copy link
Contributor

I continuous failing to build PHP 8.2 on CentOS 7.
May need to merge into PHP-8.2 branch.

@iluuu1994
Copy link
Member Author

Oh, yes of course. I initially didn't because of the BC break but I missed that this caused compilation issues on PHP-8.2 as well.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@devnexen devnexen devnexen approved these changes

@Girgias Girgias Girgias approved these changes

Assignees
No one assigned
Labels
SAPI: fpm
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Replace php_reallocarray with safe_perealloc
4 participants
@iluuu1994 @zeriyoshi @devnexen @Girgias