Add FormTypeExtensionInterface stub

[pscheit-lillydoo]

Since it implements nearly the same interface, but isn't typehinted either ($options missing iterable type)

How can I test that?

[pscheit-lillydoo]

Thank you for writing phpstan!

I accept the code of conduct in phpstan/phpstan-src

Greetings

[ondrejmirtes]

Hi, what kind of bug this solves? Thank you.

[pscheit-lillydoo]

use \Symfony\Component\Form\FormTypeExtensionInterface;

Class MyTypeExtension implements FormTypeExtensionInterface
{
    public function buildForm(FormBuilderInterface $builder, array $options)
    {
    }
\

phpstan would say:

$options type has no value type specified in iterable type array

its the same case as the FormTypeInterface Stub

[ondrejmirtes]

How does the $options array going into these methods usually looks like?

[pscheit-lillydoo]

e.g. for a collection type

 [
    'entry_type' => EmailType::class,
    'entry_options' => [
        'attr' => ['class' => 'email-box'],
    ],
]);

basically everything mentioned here https://symfony.com/doc/current/reference/forms/types.html#other-fields
listed as options of the form types.
But could be custom options, too, depends on the formType (if it is a custom one, too)

[ondrejmirtes]

So is it array<string, mixed>?

[pscheit-lillydoo]

yes sir, exactly as stated in the stub

[pscheit-lillydoo]

this is the correct type

[ondrejmirtes]

Nope, your stub says array<mixed>.

[pscheit-lillydoo]

arg, right 👍

but then its the same case as for
stubs/FormTypeInterface.stub

should I create a PR to fix it there, too?

[ondrejmirtes]

Push the fix here in this PR, thanks.

[ondrejmirtes]

Thank you, tagged as 0.12.10.