[FIX] Issue #670: Slow website picocss.com#718
Open
benhovinga wants to merge 3 commits intopicocss:devfrom
Open
[FIX] Issue #670: Slow website picocss.com#718benhovinga wants to merge 3 commits intopicocss:devfrom
benhovinga wants to merge 3 commits intopicocss:devfrom
Conversation
Author
|
I set the PR as draft until I am able to test the changes worked. I am traveling and don't have access to a MacOS device until I return home. I will mark this PR as ready when I have the chance to test it, or someone from the community tests it and confirms the issue is fixed. |
Author
|
Testing completed and the fix has worked. Will mark PR as ready. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue #670 describes a performance issue that is caused by the shadow helper function. This issue only affects MacOS devices with Apple Silicon.
This PR aims to fix the issue by removing the complex shadow helper function and replacing it with a much simpler and performant box-shadow attribute.
Closes #670