Swift 5 #13
Merged
Swift 5 #13
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
houndci-bot
reviewed
Aug 10, 2019
| pod "Hue", "~> 2.0.0" | ||
| pod "Kingfisher", "~> 3.2.0" | ||
| pod "Hue", git: "https://github.com/zenangst/Hue.git", tag: "5.0.0" | ||
| pod "Kingfisher", git: "https://github.com/onevcat/Kingfisher.git", tag: "5.7.0" |
There was a problem hiding this comment.
Metrics/LineLength: Line is too long. [82/80]
|
|
||
| target :iCookTV do | ||
| pod "Alamofire", "~> 4.2.0" | ||
| pod "Alamofire", git: "https://github.com/Alamofire/Alamofire.git", tag: "4.8.2" |
There was a problem hiding this comment.
Metrics/LineLength: Line is too long. [82/80]
Codecov Report
|
Codecov Report
|
9fe8be1 to
908f693
Compare
908f693 to
fe4b5fa
Compare
dlackty
approved these changes
Jan 21, 2020
Generated by 🚫 Danger |
Member
|
@bcylin sorry for delaying so long. Could you please help rebase it and I'm gonna merge it then wrap up a new version. |
9798751 to
ce5c3f3
Compare
Member
|
@bcylin Thanks! Much appreciated. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Part the subsequent updates of #9. Update the codebase to the latest Swift syntax and Xcode 10.3.
⬜️ Remove R.swift
⬜️ Replace Freddy with Swift Codable
⬜️ Replace Quick and Nimble with XCTest
✅ Update the project to Xcode 10.3 with Swift 5