Skip to content

Conversation

@dlackty
Copy link
Member

@dlackty dlackty commented Apr 26, 2020

  • Remove Treasure Data SDK
  • Migrate Crashlytics from Fabric to Firebase
  • Drop Fabric Answers as there's no replacement from Firebase yet
  • Use Facebook Analytics

Podfile Outdated
pod "Alamofire", "4.8.2"
pod "Crashlytics"
pod "Fabric"
pod 'Firebase/Crashlytics'

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Style/StringLiterals: Prefer double-quoted strings unless you need single quotes to avoid extra backslashes for escaping.

@github-actions
Copy link

1 Error
🚫 Please update CHANGELOG.md.

Generated by 🚫 Danger

@dlackty dlackty force-pushed the feature/clean-up-trackings branch from ca1575a to a74b1d6 Compare April 26, 2020 07:54
@codecov
Copy link

codecov bot commented Apr 26, 2020

Codecov Report

Merging #15 into develop will increase coverage by 3.93%.
The diff coverage is 100.00%.

Impacted Files Coverage Δ
iCookTV/AppDelegate.swift 70.00% <ø> (+38.18%) ⬆️
iCookTV/iCookTVKeys.swift 100.00% <ø> (+66.66%) ⬆️
iCookTV/Helpers/Tracker.swift 28.00% <100.00%> (+2.00%) ⬆️
iCookTV/Helpers/GroundControl.swift 38.88% <0.00%> (+16.66%) ⬆️
iCookTV/Controllers/LaunchViewController.swift 95.50% <0.00%> (+17.97%) ⬆️
iCookTV/Protocols/DataFetching.swift 85.00% <0.00%> (+50.00%) ⬆️
iCookTV/Extensions/DataRequest+Result.swift 82.35% <0.00%> (+64.70%) ⬆️
iCookTV/Debug.swift 100.00% <0.00%> (+100.00%) ⬆️

@bcylin bcylin removed their assignment Apr 26, 2020
@bcylin bcylin self-requested a review April 26, 2020 09:15
Copy link
Collaborator

@bcylin bcylin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

plugin "cocoapods-keys", {
project: "iCookTV",
keys: ["BaseAPIURL", "CrashlyticsAPIKey", "TreasureDataAPIKey"]
keys: ["BaseAPIURL", "FacebookAppID"]

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Style/WordArray: Use %w or %W for an array of words.

@@ -1,4 +1,4 @@
source "http://rubygems.org"
source "https://rubygems.org"

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Style/FrozenStringLiteralComment: Missing magic comment # frozen_string_literal: true.

@dlackty dlackty force-pushed the feature/clean-up-trackings branch from b999a78 to dbac0db Compare April 26, 2020 16:11
@dlackty dlackty merged commit 12e0271 into develop Apr 26, 2020
@dlackty dlackty deleted the feature/clean-up-trackings branch April 26, 2020 16:18
@dlackty dlackty restored the feature/clean-up-trackings branch July 4, 2020 18:29
@dlackty dlackty deleted the feature/clean-up-trackings branch July 4, 2020 18:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Development

Successfully merging this pull request may close these issues.

4 participants