-
Notifications
You must be signed in to change notification settings - Fork 17
Clean up tracking #15
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Podfile
Outdated
| pod "Alamofire", "4.8.2" | ||
| pod "Crashlytics" | ||
| pod "Fabric" | ||
| pod 'Firebase/Crashlytics' |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Style/StringLiterals: Prefer double-quoted strings unless you need single quotes to avoid extra backslashes for escaping.
Generated by 🚫 Danger |
ca1575a to
a74b1d6
Compare
Codecov Report
|
bcylin
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍
| plugin "cocoapods-keys", { | ||
| project: "iCookTV", | ||
| keys: ["BaseAPIURL", "CrashlyticsAPIKey", "TreasureDataAPIKey"] | ||
| keys: ["BaseAPIURL", "FacebookAppID"] |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Style/WordArray: Use %w or %W for an array of words.
| @@ -1,4 +1,4 @@ | |||
| source "http://rubygems.org" | |||
| source "https://rubygems.org" | |||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Style/FrozenStringLiteralComment: Missing magic comment # frozen_string_literal: true.
b999a78 to
dbac0db
Compare
Uh oh!
There was an error while loading. Please reload this page.