Skip to content

Conversation

@bcylin
Copy link
Collaborator

@bcylin bcylin commented Dec 11, 2016

  • Simplify the steps for OSS setup
  • Organize build phase scripts in separate files for better diff
  • Specify swiftlint version
  • Add -D TRACKING flag to skip analytics in the debug configuration

@bcylin bcylin requested a review from dlackty December 11, 2016 11:13
elif [ $(swiftlint version) != "$SWIFTLINT_VERSION" ]; then
brew upgrade swiftlint
else
swiftlint
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This should be placed outside of else clause?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes indeed 👍

@codecov-io
Copy link

codecov-io commented Dec 11, 2016

Current coverage is 16.25% (diff: 34.00%)

Merging #6 into develop will increase coverage by 2.50%

@@            develop         #6   diff @@
==========================================
  Files            43         43          
  Lines          1360       1372    +12   
  Methods           0          0          
  Messages          0          0          
  Branches          0          0          
==========================================
+ Hits            187        223    +36   
+ Misses         1173       1149    -24   
  Partials          0          0          

Powered by Codecov. Last update a51525b...f97d3fe

@bcylin bcylin merged commit fe62a9d into develop Dec 23, 2016
@bcylin bcylin deleted the feature/build-scripts branch December 23, 2016 12:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Development

Successfully merging this pull request may close these issues.

4 participants