Skip to content

Migrate POI kind and kindDetail assigment from plain Java to MultiExpression rules #537

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Draft
migurski wants to merge 13 commits into
base: main
Choose a base branch
from
Draft

Migrate POI kind and kindDetail assigment from plain Java to MultiExpression rules #537

migurski wants to merge 13 commits into from
+119 −98

Conversation

@migurski
Copy link
Contributor

@migurski migurski commented Dec 26, 2025 •
edited
Loading

Migrate from plain Java conditionals to MultiExpression rules when applying POI kind and kindDetail. Removes some dense logic from processOsm(), passes all existing tests with no changes required.

Open questions:

  • Should this PR be expanded to cover the minZoom assignments also, or would that be better in a future PR?
  • Is there any meaningful performance impact?

@sonarqubecloud
Copy link

sonarqubecloud bot commented Dec 26, 2025

Quality Gate Passed Quality Gate passed

Issues
1 New issue
0 Accepted issues

Measures
0 Security Hotspots
95.5% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

1 participant

@migurski