Fix: Preserve parentheses when merging # type: ignore with other comments to prevent AST errors #4888
+67
−0
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Closes #4880
This PR fixes issue #4880 by ensuring that Black does not omit optional parentheses when doing so would merge a
# type: ignorecomment with other comments on the same line. Merging these comments causes Python's AST parser to lose theTypeIgnorenode, resulting in AST equivalence failures and internal errors. The pr updates the logic incan_omit_invisible_parens()to detect and prevent this specific case.Checklist - did you ...
--previewstyle, following the stability policy?CHANGES.mdif necessary?