-
-
Notifications
You must be signed in to change notification settings - Fork 309
Wrong inference with default argument values #2914
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #2914 +/- ##
=======================================
Coverage 93.42% 93.42%
=======================================
Files 92 92
Lines 11223 11230 +7
=======================================
+ Hits 10485 10492 +7
Misses 738 738
Flags with carried forward coverage won't be shown. Click here to find out more.
🚀 New features to boost your workflow:
|
|
Thank you for opening the PR @jkmnt. This look reasonable to me. I'm going to have to approve the pipeline each time online because this is your first contribution, but you can install pre-commit locally to launch the linter. |
|
Ok! Installed local pre-commit and added another test to increase changes coverage. |
This is a q&d draft PR fixing #2899: Wrong inference with default argument values.
I've added the same test as in reported issue.
I'm not an expert on Astroid. Maybe it brokes something else.
pytest -k inferenceis passing ok.Closes #2899