Skip to content

Conversation

@jkmnt
Copy link

@jkmnt jkmnt commented Dec 16, 2025

This is a q&d draft PR fixing #2899: Wrong inference with default argument values.
I've added the same test as in reported issue.

I'm not an expert on Astroid. Maybe it brokes something else. pytest -k inference is passing ok.

Closes #2899

@codecov
Copy link

codecov bot commented Dec 16, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 93.42%. Comparing base (dbb5054) to head (7ea737c).

Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff           @@
##             main    #2914   +/-   ##
=======================================
  Coverage   93.42%   93.42%           
=======================================
  Files          92       92           
  Lines       11223    11230    +7     
=======================================
+ Hits        10485    10492    +7     
  Misses        738      738           
Flag Coverage Δ
linux 93.27% <100.00%> (-0.02%) ⬇️
pypy 93.42% <100.00%> (+<0.01%) ⬆️
windows 93.41% <100.00%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines Coverage Δ
astroid/nodes/node_classes.py 95.08% <100.00%> (+0.06%) ⬆️

... and 1 file with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@Pierre-Sassoulas
Copy link
Member

Thank you for opening the PR @jkmnt. This look reasonable to me. I'm going to have to approve the pipeline each time online because this is your first contribution, but you can install pre-commit locally to launch the linter.

@jkmnt
Copy link
Author

jkmnt commented Dec 16, 2025

Ok! Installed local pre-commit and added another test to increase changes coverage.

@jkmnt jkmnt marked this pull request as ready for review December 16, 2025 19:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Wrong inference with default argument values

2 participants